Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added and Fixed 2019-01-29 Node EOL Deprecation Timeline Image #967

Merged
merged 1 commit into from
Apr 12, 2019
Merged

Added and Fixed 2019-01-29 Node EOL Deprecation Timeline Image #967

merged 1 commit into from
Apr 12, 2019

Conversation

erisu
Copy link
Member

@erisu erisu commented Apr 12, 2019

Platforms affected

none

Motivation and Context

Missing Image

Description

  • Added Image
  • Added header to image section
  • Fixed misspelling in image alt

Testing

  • Built
  • Ran test server

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

dpogue
dpogue approved these changes Apr 12, 2019
View reviewed changes
Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@erisu erisu merged commit 96af3db into apache:master Apr 12, 2019
@erisu erisu mentioned this pull request May 16, 2019
Closed
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpogue dpogue dpogue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erisu @dpogue